moggaa commented on code in PR #17653:
URL: https://github.com/apache/iceberg/pull/17653#discussion_r4121981732
##########
docs/docs/kafka-connect.md:
##########
@@ -71,6 +71,7 @@ for exactly-once semantics. This requires Kafka 2.5 or later.
| iceberg.tables.evolve-schema-enabled | Set to `true` to add any
missing record fields to the table schema, default is `false`
|
| iceberg.tables.schema-force-optional | Set to `true` to set columns as
optional during table create and evolution, default is `false` to respect
schema |
| iceberg.tables.schema-case-insensitive | Set to `true` to look up table
columns by case-insensitive name, default is `false` for case-sensitive
|
+| iceberg.tables.replace-null-with-default | Set to `false` to preserve
explicit null values instead of replacing them with the record schema default
value, default is `true` |
Review Comment:
Added the note in d585a0d49: with the option off, a required column cannot
take an explicit null and the write fails, with
`iceberg.tables.schema-force-optional=true` (or altering the columns) as the
mitigation. Took the optional suggestion too — in 13d704898, `RecordConverter`
now logs a warning when an explicit null lands on a required column, skipped
when schema evolution is about to make the column optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
