nssalian commented on code in PR #9:
URL:
https://github.com/apache/iceberg-verification/pull/9#discussion_r4137729735
##########
table-spec/types/geospatial/cases.json:
##########
@@ -0,0 +1,106 @@
+{
+ "cases": [
+ {
+ "id": "geometry-crs84",
+ "valid": true,
+ "normative_level": "should",
+ "input": "geometry(OGC:CRS84)",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
+ "canonical": "geometry(OGC:CRS84)",
+ "clause": "geometry(C) with explicit CRS; Appendix C's canonical is
fully parameterized, but when C is the default OGC:CRS84 whether a writer may
elide it is unsettled, so the write direction is advisory",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-srid",
+ "valid": true,
+ "input": "geometry(srid:4326)",
+ "decoded": {"type": "geometry", "crs": "srid:4326"},
+ "canonical": "geometry(srid:4326)",
+ "clause": "geometry(C) example from Appendix C is the unquoted
\"geometry(srid:4326)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-default-crs",
+ "valid": true,
+ "normative_level": "should",
+ "input": "geometry",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
+ "canonical": "geometry(OGC:CRS84)",
+ "clause": "geometry(C): if C is not specified, C is OGC:CRS84; Appendix
C's canonical is fully parameterized, but whether a writer may elide the
default is unsettled, so the write direction is advisory",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geography-crs84-spherical",
+ "valid": true,
+ "normative_level": "should",
+ "input": "geography(OGC:CRS84, spherical)",
+ "decoded": {"type": "geography", "crs": "OGC:CRS84", "algorithm":
"spherical"},
+ "canonical": "geography(OGC:CRS84, spherical)",
+ "clause": "geography(C, A) with explicit CRS and algorithm; Appendix C's
canonical is fully parameterized, but when C/A are the defaults
OGC:CRS84/spherical whether a writer may elide them is unsettled, so the write
direction is advisory",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geography-default",
+ "valid": true,
+ "normative_level": "should",
+ "input": "geography",
+ "decoded": {"type": "geography", "crs": "OGC:CRS84", "algorithm":
"spherical"},
+ "canonical": "geography(OGC:CRS84, spherical)",
+ "clause": "geography(C, A): if not specified, C is OGC:CRS84 and A is
spherical; Appendix C's canonical is fully parameterized, but whether a writer
may elide the default is unsettled, so the write direction is advisory",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geography-crs-only",
+ "valid": true,
+ "normative_level": "should",
+ "input": "geography(OGC:CRS84)",
+ "decoded": {"type": "geography", "crs": "OGC:CRS84", "algorithm":
"spherical"},
+ "canonical": "geography(OGC:CRS84, spherical)",
+ "clause": "geography(C, A): if A is unspecified but C is given, A
defaults to spherical (Java reference behavior; Appendix C defines
geography(<C>, <A>) as canonical)",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
Review Comment:
The clause now states the 1-arg `geography(C)` form is not in Appendix C
grammar and is cross-checked against Java reference behavior, which defaults
the algorithm to spherical and re-serializes to the Appendix C canonical
`geography(<C>, <A>)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
