nssalian commented on code in PR #9:
URL:
https://github.com/apache/iceberg-verification/pull/9#discussion_r4137713478
##########
table-spec/types/geospatial/cases.json:
##########
@@ -0,0 +1,106 @@
+{
+ "cases": [
+ {
+ "id": "geometry-crs84",
+ "valid": true,
Review Comment:
I think for the bare-input cases: I split each into a `must` parse case
(decoded only, no `canonical`, citing the default rule at spec.md:284-285) and
a `should` `-write` case carrying the `canonical` for the elision direction. A
parser that skips the default now fails hard; only the write elision is
advisory.
##########
table-spec/types/geospatial/cases.json:
##########
@@ -0,0 +1,106 @@
+{
+ "cases": [
+ {
+ "id": "geometry-crs84",
+ "valid": true,
Review Comment:
For the bare-input cases: I split each into a `must` parse case (decoded
only, no `canonical`, citing the default rule at spec.md:284-285) and a
`should` `-write` case carrying the `canonical` for the elision direction. A
parser that skips the default now fails hard; only the write elision is
advisory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
