moomindani commented on code in PR #9:
URL:
https://github.com/apache/iceberg-verification/pull/9#discussion_r4139901845
##########
table-spec/types/geospatial/cases.json:
##########
@@ -0,0 +1,83 @@
+{
+ "cases": [
+ {
+ "id": "geometry-crs84",
+ "valid": true,
+ "input": "geometry(OGC:CRS84)",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
+ "clause": "geometry(C) with explicit CRS; the canonical serialized form
is unquoted \"geometry(<C>)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-srid",
+ "valid": true,
+ "input": "geometry(srid:4326)",
+ "decoded": {"type": "geometry", "crs": "srid:4326"},
+ "clause": "geometry(C) example from Appendix C is the unquoted
\"geometry(srid:4326)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-default-crs",
+ "valid": true,
+ "input": "geometry",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
Review Comment:
Agreed on the parse side. The gap is the `canonical` this case keeps:
PyIceberg writes an explicitly supplied `OGC:CRS84` back as bare `geometry`, so
as `must` it fails on the same elision question `geometry-default-crs-write`
now isolates as `should`. Splitting it the same way (a `must` parse case plus a
`should` `-write` case) would keep the two consistent — fine as a follow-up
rather than holding this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
