KranzL commented on PR #2041: URL: https://github.com/apache/iceberg-go/pull/2041#issuecomment-5902136468
All three round-2 threads are addressed and the branch is rebased onto origin/main at 861b4ca. 6c9a36e wires cleanupAtomicRewriteOutputs into the rewrite.Commit failure branch, opens the table IO once up front with cleanup taking the open handle, and switches error selection to lowest-index-not-canceled with every group failure logged via slog. Cancellation now broadcasts over a plain WithCancel context: with errgroup.WithContext, a still-running sibling scan iterator surfaced the failing group error value through context.Cause instead of context.Canceled, which the new ordering test caught. 1116187 adds the three regression tests; each fails on the pre-fix code and passes after. The rebase drops the data_file_codec.go hunks that duplicated #2052 and keeps only the additive timestamp round-trip coverage, noted in the description. go test ./table/... -race -count=1 passes (table 37.4s, compaction 13.7s, dv 3.5s, internal 4.6s, substrait 2.1s); golangci-lint reports 0 issues on ./table/...; the benchmark still shows the 1 to 8 speedup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
