anoopj commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4140061845
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -468,8 +472,10 @@ private Schema readSchema(boolean includePartition) {
ImmutableMap.of(TrackedFile.TRACKING.fieldId(),
TrackingStruct.BASE_TYPE));
if (requestedProjection != null) {
+ boolean projectsPartition =
+ includePartition ||
requestedProjection.findField(TrackedFile.PARTITION_ID) != null;
Review Comment:
Exactly. It makes sure the whole partition struct are read whenever any
partition field is needed. The caller can select a sub-field (e.g.
`partition.id`). Restoring widens it to the full union tuple and pulls in
`spec_id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
