rdblue commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4148590408
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -80,14 +82,16 @@ class TrackedFileStruct extends SupportsIndexProjection
implements TrackedFile,
private long[] splitOffsets = null;
private int[] equalityIds = null;
+ private transient StructProjection partitionProjection = null;
+
/** Used by internal readers to instantiate this class with a projection
schema. */
TrackedFileStruct(Types.StructType projection) {
super(BASE_TYPE, projection);
// partition type may be null if the field was not projected, or unknown
for unpartitioned
// manifests
Type partType = projection.fieldType(TrackedFile.PARTITION_NAME);
if (partType != null && partType.isStructType()) {
- this.partitionData = new PartitionData(partType.asStructType());
+ this.partition = new PartitionData(partType.asStructType());
Review Comment:
It looks like this is not using the typical path for injecting a class for
`InternalData` readers. Couldn't this just set `PartitionData.class` for the
partition's field ID in the manifest reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
