rdblue commented on a change in pull request #2046:
URL: https://github.com/apache/iceberg/pull/2046#discussion_r561141146



##########
File path: core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
##########
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-package org.apache.iceberg.mr;
+package org.apache.iceberg.util;

Review comment:
       I would rather not expose this class in core just for tests. Could you 
copy the methods into `TestHelpers` or embed them in the test suites instead? 
That would cut down on a lot of files touched by this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to