rdblue commented on a change in pull request #2046:
URL: https://github.com/apache/iceberg/pull/2046#discussion_r561144480
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -186,4 +194,34 @@ public Transaction newTransaction() {
public String toString() {
return name();
}
+
+ abstract Object writeReplace();
Review comment:
This object has access to `table()`, `io()`, and `name()` already. Would
it be easier to expose protected `metadataLocation()` and `metadataTableType()`
methods instead of `writeReplace()` in each implementation? Then this method
could be implemented here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
