kinolaev commented on PR #18507: URL: https://github.com/apache/iceberg/pull/18507#issuecomment-6212161655
Thanks @mxm for the review! I've addressed your comments above. Regarding `TestDynamicIcebergSink`, I found that the bug occurs not only on table updates but also on table creation. I parameterized `testUpsert` and `testUpsertV3` with `immediateUpdate` and made the record schema field IDs differ from those the catalog assigns on table creation. In `testUpsertV3`, the sink now creates the table through a `TableCreator`, instead of the test creating it up front. I also disabled automatic restarts: a restart replays the records against the already created table, which hid the failure. With `immediateUpdate` disabled and without the fix, both tests now fail. Thanks for pointing out these tests! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
