gaborkaszab commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4347932377


##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -134,7 +135,7 @@ public CloseableIterator<TrackedFile> iterator() {
           CloseableIterable.filter(
               this::incrementSkipCount,
               files,
-              file -> statsFilter.eval(file.contentStats(), 
file.recordCount()));
+              file -> statsFilter.eval(statsForFiltering(file), 
file.recordCount()));

Review Comment:
   Yes. From [the 
spec](https://iceberg.apache.org/spec/#equality-delete-files): `Equality delete 
files referenced by v2 or v3 delete manifests must still be applied in a v4 
table.` So, eq-deletes can still be present in metadata within delete 
manifests, referenced from the root manifest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to