findinpath commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4361285672
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -181,6 +182,20 @@ private boolean isDeletedByMDV(TrackedFile file) {
return dv.isSet(Math.toIntExact(file.tracking().manifestPos()));
}
+ private static ContentStats statsForFiltering(TrackedFile file) {
+ ContentStats stats = file.contentStats();
+ if (stats == null || file.contentType() != FileContent.EQUALITY_DELETES) {
Review Comment:
Agreed, v4 can't carry equality deletes. Removed the V4ManifestReader change
and its test.
https://github.com/apache/iceberg/blob/2856631da4d81e79ece85c3694bfd81a86ca612e/format/spec.md?plain=1#L1635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
