gaborkaszab commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4348696682
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -181,6 +182,20 @@ private boolean isDeletedByMDV(TrackedFile file) {
return dv.isSet(Math.toIntExact(file.tracking().manifestPos()));
}
+ private static ContentStats statsForFiltering(TrackedFile file) {
+ ContentStats stats = file.contentStats();
+ if (stats == null || file.contentType() != FileContent.EQUALITY_DELETES) {
Review Comment:
`TrackedFile` can't have content type for eq-deletes. What is possible is to
have a `TrackedFile` in the root manifest with the content type of
`DELETE_MANIFEST` that in turn will contain eq-deletes, but that won't go
through this code path. However, `DELETE_MANIFEST`s don't have equalityIds so
below we won't filter anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
