swapna267 commented on code in PR #18661:
URL: https://github.com/apache/iceberg/pull/18661#discussion_r4403327357
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestRewriteDataFiles.java:
##########
@@ -619,34 +621,59 @@ void testRewriteWithFilterSupplier() throws Exception {
@Test
void testBranch() throws Exception {
+ Table table = createTableWithBranch(TEST_BRANCH);
+
+ rewriteAndAssertBranchCompacted(
+ table,
RewriteDataFiles.builder().rewriteAll(true).branch(TEST_BRANCH));
+ }
+
+ @Test
+ void testRewriteOnCustomBranch() throws Exception {
Review Comment:
I think it doesn't add much value if we just add the test for rewriting the
custom branch by passing the override in the config.
I will add a test in `TestIcebergSinkTableMaintenance` to cover the behavior
change in IcebergSink, when EqualityDelete conversion task is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
