swapna267 commented on code in PR #18661:
URL: https://github.com/apache/iceberg/pull/18661#discussion_r4405389883
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFilesConfig.java:
##########
@@ -30,6 +30,13 @@
public class RewriteDataFilesConfig {
public static final String PREFIX = FlinkMaintenanceConfig.PREFIX +
"rewrite.";
+ public static final String BRANCH = PREFIX + "branch";
+ public static final ConfigOption<String> BRANCH_OPTION =
+ ConfigOptions.key(BRANCH)
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The branch to compact. Defaults to the sink's
write branch.");
Review Comment:
I currently made it to reject if this config is not set when
convert-equality-deletes is on , and target branch specified is different from
Sink's branch.
Made to reject, so user explicitly aware of the behavior.
In this specific scenario, as user always need to set it to targetbranch, we
can also default it.
Wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
