swapna267 commented on code in PR #18661: URL: https://github.com/apache/iceberg/pull/18661#discussion_r4417230789
########## docs/docs/flink-maintenance.md: ########## @@ -505,10 +505,13 @@ These keys are used in SQL (SET or table WITH options) or via `IcebergSink.Build | `flink-maintenance.rewrite.schedule.data-file-count` | Trigger after N data files | `1000` | | `flink-maintenance.rewrite.schedule.data-file-size` | Trigger after total data file size (bytes) | `107374182400` (100GB) | | `flink-maintenance.rewrite.schedule.interval-second` | Trigger after time interval (seconds) | `600` | +| `flink-maintenance.rewrite.branch` | Branch to compact. Set it to compact a different branch than the one the sink writes to, e.g. `main` when the sink writes to a staging branch | Not set | | `flink-maintenance.rewrite.max-bytes` | Maximum bytes to rewrite per execution | `Long.MAX_VALUE` | | `flink-maintenance.rewrite.partial-progress.enabled` | Enable partial progress commits | `false` | | `flink-maintenance.rewrite.partial-progress.max-commits` | Maximum commits for partial progress | `10` | +When rewrite data files and convert equality deletes are both enabled and `flink-maintenance.convert-equality-deletes.target-branch` is set to a branch other than the sink's write branch, set `flink-maintenance.rewrite.branch` explicitly to the branch to rewrite. Review Comment: For logic i pushed in previous commit, I was not defaulting to the convert target branch, but letting user to explicitly set it to convert target branch. If we are defaulting to convert target branch when rewrite data files and convert equality deletes are both enabled, I think we can remove this note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
