rdblue commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4447567477
##########
core/src/test/java/org/apache/iceberg/TestStatsUtil.java:
##########
@@ -277,12 +269,12 @@ public void testStringNoneMode() {
@Test
public void testStringCountsMode() {
- // counts mode drops the bounds (and tight_bounds) but keeps counts and
the value size
+ // counts mode drops the bounds but keeps counts and the value size
Types.StructType expected =
Types.StructType.of(
- Types.NestedField.optional(30_004, "value_count",
Types.LongType.get()),
- Types.NestedField.optional(30_005, "null_value_count",
Types.LongType.get()),
- Types.NestedField.optional(30_007, "total_bytes",
Types.LongType.get()));
+ Types.NestedField.optional(30_003, "value_count",
Types.LongType.get()),
+ Types.NestedField.optional(30_004, "null_value_count",
Types.LongType.get()),
+ Types.NestedField.optional(30_006, "total_bytes",
Types.LongType.get()));
Review Comment:
There are a ton of changes here because this changes the offsets. Seems like
that was unnecessary and causing additional headache, code churn, and risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
