anoopj commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4447860853
##########
core/src/test/java/org/apache/iceberg/TestStatsUtil.java:
##########
@@ -277,12 +269,12 @@ public void testStringNoneMode() {
@Test
public void testStringCountsMode() {
- // counts mode drops the bounds (and tight_bounds) but keeps counts and
the value size
+ // counts mode drops the bounds but keeps counts and the value size
Types.StructType expected =
Types.StructType.of(
- Types.NestedField.optional(30_004, "value_count",
Types.LongType.get()),
- Types.NestedField.optional(30_005, "null_value_count",
Types.LongType.get()),
- Types.NestedField.optional(30_007, "total_bytes",
Types.LongType.get()));
+ Types.NestedField.optional(30_003, "value_count",
Types.LongType.get()),
+ Types.NestedField.optional(30_004, "null_value_count",
Types.LongType.get()),
+ Types.NestedField.optional(30_006, "total_bytes",
Types.LongType.get()));
Review Comment:
I do agree. I initially left it alone, but changed it from PR feedback to
adjust it. We traded off a lack of gap in the spec to this churn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
