dramaticlly commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4448946036
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -143,6 +147,7 @@ private TrackedFileStruct(TrackedFileStruct toCopy,
Set<Integer> statsIds) {
this.contentStats = null;
}
+ this.tightStats = toCopy.tightStats;
Review Comment:
qq: if no content stats is available like in LINE147, probably should not
not carry over the tightness flag?
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -291,6 +302,7 @@ void copyWithoutStats() {
assertThat(copy.fileSizeInBytes()).isEqualTo(512L);
assertThat(copy.specId()).isEqualTo(1);
assertThat(copy.contentStats()).isNull();
+ assertThat(copy.hasTightStats()).isTrue();
Review Comment:
qq: should tightness evaluated to false instead if copied without stats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
