nastra commented on code in PR #14590:
URL: https://github.com/apache/iceberg/pull/14590#discussion_r4443031624
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -54,7 +54,7 @@ public class AuthSessionCache implements AutoCloseable {
public AuthSessionCache(String name, Duration sessionTimeout) {
this(
sessionTimeout,
- ThreadPools.newExitingWorkerPool(name + "-auth-session-evict", 1),
+ ThreadPools.newFixedThreadPool(name + "-auth-session-evict", 1),
Review Comment:
the exiting worker pool also uses daemon threads but it also registers a
shutdown hook in order to ensure that the pool terminates when the JVM exits. I
don't think we should be changing this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
