pvary commented on PR #14590: URL: https://github.com/apache/iceberg/pull/14590#issuecomment-6601609084
We had several discussions around these lines. - Closing catalogs - Every time we ended up saying that we don't want Catalogs to own resources, so no close should be necessary. JDBC, HMS Pools are shared and not closed when a catalog is not used anymore. A new catalog will reuse the same resources. - ExitingWorkerPools - Flink and other engines which reuse JVMs has serious issues with `ExitingWorkerPools` as they are stuck and referenced by the classloader. We wanted to change them: #15031, #15312. I think the most relevant is https://github.com/apache/iceberg/pull/15312#issuecomment-4348265412. My take is: - Do we really want to tie the pool to the Catalog? Catalogs are often recreated, and we don't handle lifecycle for them. - Shall we have our own lifecycle for the AuthSession threadpool? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
