nastra commented on code in PR #14590:
URL: https://github.com/apache/iceberg/pull/14590#discussion_r4453296709
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -54,7 +54,7 @@ public class AuthSessionCache implements AutoCloseable {
public AuthSessionCache(String name, Duration sessionTimeout) {
this(
sessionTimeout,
- ThreadPools.newExitingWorkerPool(name + "-auth-session-evict", 1),
+ ThreadPools.newFixedThreadPool(name + "-auth-session-evict", 1),
Review Comment:
Ah right, I forgot that this accumulates shutdown hooks in the JVM. @adutra
do you maybe recall why we picked `ThreadPools.newExitingWorkerPool` here back
then? I think using `newFixedThreadPool` should be fine here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
