openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r566057769
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java
##########
@@ -62,9 +61,8 @@ private TestHelpers() {
}
public static RowData copyRowData(RowData from, RowType rowType) {
- ExecutionConfig config = new ExecutionConfig();
TypeSerializer[] fieldSerializers = rowType.getChildren().stream()
- .map((LogicalType type) -> InternalSerializers.create(type, config))
+ .map((LogicalType type) -> InternalSerializers.create(type))
Review comment:
I'd prefer to create our iceberg's `RowDataCloner` (which is similar to
the
[RowDataConvert](https://github.com/apache/iceberg/blob/78e80d2a35c4c93e68776c31c24cc8ccb06fed4b/flink/src/test/java/org/apache/iceberg/flink/RowDataConverter.java#L49)
), so that we could get ride of this flink internal `InternalSerializers`.
Relying on flink internal interfaces that do not promise compatibility
should be avoided as much as possible in subsequent development codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
