openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r566060147
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
##########
@@ -52,12 +53,25 @@ public TestFlinkScanSql(String fileFormat) {
@Override
public void before() throws IOException {
super.before();
- tEnv =
TableEnvironment.create(EnvironmentSettings.newInstance().useBlinkPlanner().inBatchMode().build());
- tEnv.executeSql(String.format(
+ getTableEnv().executeSql(String.format(
Review comment:
OK, that sounds good to me.
Nit: here we could just use the `executeSQL` methods now. Maybe we could
just rename the `executeSQL(String sql)` as `sql(String query, Object...
args)`, so that we could have the same usage that is similar to the
[FlinkTestBase#sql](https://github.com/apache/iceberg/blob/543a6cdd0538e505c4ab3fa0f0876a5a22bd7704/flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java#L88).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
