smaheshwar-pltr commented on code in PR #1090:
URL: https://github.com/apache/iceberg-cpp/pull/1090#discussion_r4474830731
##########
src/iceberg/test/rest_catalog_integration_test.cc:
##########
@@ -425,6 +426,31 @@ TEST_F(RestCatalogIntegrationTest,
FetchServerConfigDirect) {
}
}
+// RestCatalog shares its HttpClient with token refresh and metrics reporting.
Review Comment:
I wonder if this is sufficient? If a regression test is preferable I can try
to think of other approaches but I don't see anything easy for me to achieve
that right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
