smaheshwar-pltr commented on code in PR #1090:
URL: https://github.com/apache/iceberg-cpp/pull/1090#discussion_r4483819133
##########
src/iceberg/test/rest_catalog_integration_test.cc:
##########
@@ -425,6 +426,31 @@ TEST_F(RestCatalogIntegrationTest,
FetchServerConfigDirect) {
}
}
+// RestCatalog shares its HttpClient with token refresh and metrics reporting.
Review Comment:
Ah realise I wasn't super clear: with 8.22.0 this fails on current main
(without this PR's fix) fairly reliable as far as I can tell. With this fix, it
passes.
But CI runs 8.18, as you say for which this bug doesn't surface for this
test. (Given we're violating libcurl's concurrency precondition, it doesn't
provide us with fixed erroneous behaviour across versions for regression
testing hence it's a bit annoying)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
