smaheshwar-pltr commented on code in PR #1090:
URL: https://github.com/apache/iceberg-cpp/pull/1090#discussion_r4483851017
##########
src/iceberg/test/http_client_test.cc:
##########
@@ -374,6 +374,22 @@ TEST(HttpClientTest, BuildsRequestUriLikeJavaHttpRequest) {
*DefaultErrorHandler::Instance(), session);
EXPECT_THAT(absolute, IsError(ErrorKind::kInvalidArgument));
EXPECT_EQ(session.request().url, "https://auth.example/token/";);
+
+ // A different path per method, so a call that fails before authenticating
can't
+ // pass by matching the URL left over from the previous call.
+ const auto& handler = *DefaultErrorHandler::Instance();
+ EXPECT_THAT(client.Get("v1/get", {}, {}, handler, session),
+ IsError(ErrorKind::kInvalidArgument));
+ EXPECT_EQ(session.request().url, "https://catalog.example/api/v1/get";);
Review Comment:
See https://github.com/apache/iceberg-cpp/pull/1090#discussion_r4483838281
for the motivation behind these new assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
