rymurr commented on pull request #2180: URL: https://github.com/apache/iceberg/pull/2180#issuecomment-769679259
Thanks a lot for fixing this @rdblue . I just went over the original patch to try and figure out what I missed. It looks like I took the `5` from: https://github.com/apache/iceberg/blob/master/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java#L42 rather than ` CatalogProperties.CLIENT_POOL_SIZE_DEFAULT`. I wonder if we should change `HiveClientPool` to use the default too? Or even better can we make the tests/code resilient to changes in pool size? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
