rymurr commented on pull request #2180: URL: https://github.com/apache/iceberg/pull/2180#issuecomment-771611181
Maybe this question is for a new issue but: What do people think about the `HiveCatalog` lifecycle in general? It has been bothering me after I ran into an issue where `HiveCatalog` was being GC-ed, hence closing the `HiveClientPool` and breaking some cached `HiveTableOperations`. I've looked into a more formal resource ownership model but it breaks a lot of unit tests as the lifetime of `HiveCatalog` isn't consistent across tests. If it is valuable to standardise the lifetime of a `HiveCatalog` in a unit test and define the lifetime in a typical user application we can discuss and I post a patch. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
