aokolnychyi commented on pull request #2180: URL: https://github.com/apache/iceberg/pull/2180#issuecomment-770062242
> Or even better can we make the tests/code resilient to changes in pool size? The simplest solution is to increase the max number of connections in the test metastore but we decided not to do so that we can catch any potential connection leaks (it did help a couple of times). > I wonder if we should change HiveClientPool to use the default too? Well, I am not sure we should default `HiveClientPool` with values from `CatalogProperties` as the pool does not technically belong to the catalog. That said, I think we should fix `HiveCatalog` constructor that just accepts a Hadoop conf. Also, I would remove the constructor from `HiveClientPool` that does not accept the pool size (it is package private and only used in one place I am suggesting to update). That way, we ensure `HiveCatalog` will always set a correct default pool size. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
