yyanyy commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4556959978


##########
format/expressions-spec.md:
##########
@@ -222,7 +222,7 @@ Note that `year`, `month`, and `hour` transforms produce 
ordinal values and not
 
 | Parameterized function name | Description                                    
                       | Source types                                           
                                      | Result type |
 
|-----------------------------|-----------------------------------------------------------------------|----------------------------------------------------------------------------------------------|-------------|
-| `bucket(N, value)`          | Hash of value, mod `N` (see [table spec 
details][bucket-ref])         | Any primitive except for `geometry`, 
`geography`, `boolean`, `float`, or `double` | `int`       |
+| `bucket(N, value)`          | Hash of value, mod `N` (see [table spec 
details][bucket-ref])         | `int`, `long`, `decimal`, `date`, `time`, 
`timestamp`, `timestamptz`, `timestamp_ns`, `timestamptz_ns`, `string`, `uuid`, 
`fixed`, `binary` | `int`       |

Review Comment:
   agreed for a follow up to avoid debating for better terms than "simple 
types" in this PR :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to