pvary commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4561515830


##########
format/spec.md:
##########
@@ -1934,6 +1945,7 @@ Lists must use the [3-level 
representation](https://github.com/apache/parquet-fo
 | **`binary`**       | `binary`                                                
                                                                                
     |                                             |                            
                                    |
 | **`struct`**       | `group`                                                 
                                                                                
     |                                             |                            
                                    |
 | **`list`**         | `3-level list`                                          
                                                                                
     | `LIST`                                      | See Parquet docs for 
3-level representation.                   |
+| **`vector(E, D)`** | `3-level list`                                          
                                                                                
     | `LIST`                                      | The outer group must 
contain a single repeated group named `list`. The `list` group must contain a 
single primitive field named `element`, marked `required` in the Parquet 
schema. The `element` field must use the same Parquet physical type as an 
Iceberg column of type E, following the mapping in this table. Each non-null 
vector must contain exactly D non-null, finite elements. |

Review Comment:
   This approach keeps our Iceberg types free of vector-specific clutter, 
cleanly covers our Float16 use cases, and provides a way for us to support 
different vector element encodings in future specs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to