danielcweeks commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4553737832


##########
format/spec.md:
##########
@@ -308,6 +310,14 @@ For details on how to serialize a schema to JSON, see 
Appendix C.
 
 [1001]: <https://portal.ogc.org/files/?artifact_id=25355> "OGC Simple feature 
access"
 
+##### Vector
+
+A `vector(E, D)` contains exactly D elements of type E, and every element is 
non-null. `float` and `double` elements must be finite: `NaN`, `+Infinity`, and 
`-Infinity` are invalid. The vector value may be null only when the vector 
field is optional.
+
+A `vector` must not be promoted to another type. No type other than `unknown` 
may be promoted to `vector`. The element type and dimension must not change. A 
`list` of element type E is not a `vector(E, D)`, even if every list instance 
contains exactly D elements.

Review Comment:
   Do we not allow valid promotions within the normal types space?  For example 
`vector(float, 512) -> vector(double, 512)`?
   
   <!-- lenses: blue-spec-review, weeks-review -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to