Revanth14 commented on PR #2582: URL: https://github.com/apache/iceberg-go/pull/2582#issuecomment-6860035279
@laskoviymishka one question for PR 2 - inspect still leans on about 20 unexported `table` helpers, and several of them depend on `table` internals, so I can't just move them to an internal package without an import cycle. I see two ways out: export them from `table`, which grows the v1 API just for inspect, or reshape them to take only `iceberg` types so they can live in a shared internal package. What do you think? I am thinking on 2nd one. But wanted to know your thoughts too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
