Revanth14 opened a new pull request, #2582:
URL: https://github.com/apache/iceberg-go/pull/2582

   ## Problem
   
   Part of #2083 (slice 2, PR 1 of 3). Code outside the inspect files depends 
on helpers that live in them: partition statistics uses the inspect partition 
aggregation, and the snapshot manifest cache uses `streamSnapshotManifests`. 
The inspect files can't move to their own package while the rest of `table` 
depends on them.
   
   ## Fix
   
   Moves those helpers into neutral `table` files and drops the `inspect` 
prefix from their names. No behavior change and no API change; everything moved 
is unexported.
   
   - `inspect_snapshot_prefetch.go` → `snapshot_manifest_stream.go` (whole 
file).
   - `inspect_partition_builder.go` → `partition_struct_builder.go` (whole 
file), plus the builder lookup helpers it uses.
   - The partition aggregate, its lookup tree, `clonePartition` and 
`coercePartition` → `partition_aggregate.go`.
   - The table-wide partition type → `unified_partition_type.go`, renamed 
`unifiedPartitionType` after Java's `Partitioning.partitionType`.
   - `inspectRecordBatchSize` → `recordBatchSize` in `arrow_utils.go`.
   
   Their tests move with them. After this, nothing outside the inspect files 
uses a name defined in them except `InspectTable`, which PR 3 moves.
   
   ## Testing
   
   Tests and benchmarks only move or are renamed; `table` has the same number 
before and after. gofmt, `go vet ./...`, `go vet -tags integration ./...` and 
`go test -race ./...` pass locally. The integration tests were not run locally. 
Lint was not run locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to