laskoviymishka commented on code in PR #2582:
URL: https://github.com/apache/iceberg-go/pull/2582#discussion_r4576032813


##########
table/inspect_partitions.go:
##########
@@ -373,7 +263,7 @@ func (i InspectTable) foldInspectPartitionManifest(
        return ctx.Err()
 }
 
-func mergeInspectPartitionAggregate(dst, src *inspectPartitionAggregate) {
+func mergeInspectPartitionAggregate(dst, src *partitionAggregate) {

Review Comment:
   Should this become `mergePartitionAggregate`, to match 
`appendPartitionAggregate` and the type it now takes? Only inspect code calls 
it (here and `inspect_partitions_parallel_test.go`), so leaving it until PR 3 
is fine too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to