rdblue commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4566635042


##########
core/src/main/java/org/apache/iceberg/BaseDistributedDataScan.java:
##########
@@ -146,6 +147,17 @@ protected PlanningMode deletePlanningMode() {
   protected CloseableIterable<ScanTask> doPlanFiles() {
     Snapshot snapshot = snapshot();
 
+    if (snapshot.rootManifestLocation() != null) {

Review Comment:
   It looks like support for distributed scan planning is not required. The 
`Table` instance must extend `SupportsDistributedScanPlanning`, which has a 
method to enable/disable, `allowDistributedPlanning`.
   
   That prevents having a `BaseDistributedTableScan` which means that we don't 
need to respect `dataPlanningMode` because the table itself doesn't allow 
distributed scanning. I think we should go with that easier solution by adding 
this to `BaseTable` (between `refresh` and `newScan`):
   
   ```java
     @Override
     public boolean allowDistributedPlanning() {
       return ops.current().formatVersion() < 4;
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to