rdblue commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4566967306
##########
core/src/test/java/org/apache/iceberg/TestFilePlanner.java:
##########
@@ -590,6 +593,25 @@ void v3ManifestLeafUnsupported(FileFormat format) throws
IOException {
.hasMessage("Cannot read manifest with format version 0: only 4 is
supported");
}
+ @ParameterizedTest
+ @FieldSource("MANIFEST_FORMATS")
+ void columnFilesUnsupported(FileFormat format) throws IOException {
Review Comment:
This should be a test for the adapter. Another reason why that is a better
strategy is that it puts the logic in one place to test. This only tests that
column files are not allowed in the root manifest and is missing a test case
for column files in leaf manifests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]