rdblue commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4566950829


##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -64,6 +64,10 @@ protected TableScan newRefinedScan(Table table, Schema 
schema, TableScanContext
   public CloseableIterable<FileScanTask> doPlanFiles() {
     Snapshot snapshot = snapshot();
 
+    if (snapshot.rootManifestLocation() != null) {
+      return planV4RootManifest(snapshot);

Review Comment:
   Since this is not needed in `BaseDistributedDataScan`, I don't think that it 
needs to be present in `SnapshotScan` and should be a private method in this 
class.



##########
core/src/main/java/org/apache/iceberg/SnapshotScan.java:
##########
@@ -185,6 +186,37 @@ public Snapshot snapshot() {
     return snapshotId() != null ? table().snapshot(snapshotId()) : 
table().currentSnapshot();
   }
 
+  /** Plans file scan tasks for a snapshot that references a v4 root manifest. 
*/
+  CloseableIterable<FileScanTask> planV4RootManifest(Snapshot snapshot) {

Review Comment:
   +1 to `newFilePlanner`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to