RussellSpitzer commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4587384601


##########
api/src/test/java/org/apache/iceberg/types/TestFileType.java:
##########
@@ -64,6 +64,52 @@ void findsNestedFieldsByName() {
     assertThat(FILE.fieldType("missing")).isNull();
   }
 
+  @Test
+  void rejectsASchemaWhereAnotherColumnHoldsADerivedId() {

Review Comment:
   I had this in my original implementation but I thought it wasn't worth the 
extra logic just to improve the message just for file types. I think you can 
see in the commit history the version where it does first a pass to find file 
types and then checks all the offset field ids. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to