RussellSpitzer commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4590569257


##########
core/src/main/java/org/apache/iceberg/SchemaOrder.java:
##########
@@ -110,6 +110,11 @@ public List<Integer> map(
       return null;
     }
 
+    @Override
+    public List<Integer> file(Types.FileType file, Iterable<List<Integer>> 
fieldResults) {
+      return struct(file.asStruct(), fieldResults);

Review Comment:
   That makes sense. I switched this around and added a property of FileType 
`defaultInferredMetricOffsets` which gets called here to assign the fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to