RussellSpitzer commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4590356911


##########
api/src/main/java/org/apache/iceberg/types/CheckCompatibility.java:
##########
@@ -260,6 +260,16 @@ public List<String> variant(Types.VariantType readVariant) 
{
     return ImmutableList.of(String.format(": %s cannot be read as a %s", 
currentType, readVariant));
   }
 
+  @Override
+  public List<String> file(Types.FileType readFile, Iterable<List<String>> 
fieldErrorLists) {
+    if (currentType.isFileType()) {
+      // the nested fields are derived from the base id, so matching ids means 
matching fields

Review Comment:
   I was just trying to make sure folks would understand why we aren't checking 
the nested fields. I'll strip it out 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to