wgtmac opened a new pull request, #1140: URL: https://github.com/apache/iceberg-cpp/pull/1140
`TransactionContext` keeps a shared `Table`, but its metadata builder only borrows the base metadata. Refreshing that table while a transaction is pending can release the base, leaving a dangling pointer and allowing address reuse to hide a metadata change. Retain the builder's base in the context and replace it together with the builder during rebase. This also makes the retry-local keepalive unnecessary. The regression uses a `weak_ptr` to verify that caller refresh does not release the base, rebase releases the old base, and the commit preserves both transaction and concurrent property updates. It fails on unmodified main without relying on allocator address reuse. Found while investigating the Windows failure in #1104. This fix is independent of transaction replay file cleanup. Validation: - Regression fails before the fix and passes afterward. - Full `table_update_test` and `cpp20_compatibility_test` pass (Debug, C++20-compatible API). - `pre-commit` and `git diff --check` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
