wgtmac commented on code in PR #1140:
URL: https://github.com/apache/iceberg-cpp/pull/1140#discussion_r4616293761
##########
src/iceberg/transaction.cc:
##########
@@ -557,8 +555,9 @@ Result<std::shared_ptr<Table>> Transaction::CommitOnce(bool
is_first_attempt) {
ICEBERG_CHECK(CanRetry(),
"Cannot rebase a transaction containing a non-retryable
update");
CleanupUpdates();
- ctx_->metadata_builder =
- TableMetadataBuilder::BuildFrom(ctx_->table->metadata().get());
+ auto base_metadata = ctx_->table->metadata();
Review Comment:
> TableMetadataBuilder::BuildFrom to take base as a shared pointer
That would require significant change which I'm hesitant to make.
I've added `ResetMetadataBuilder` to update the retained base and builder
together now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]