dino-saurabh commented on code in PR #1140:
URL: https://github.com/apache/iceberg-cpp/pull/1140#discussion_r4615038255


##########
src/iceberg/transaction.cc:
##########
@@ -557,8 +555,9 @@ Result<std::shared_ptr<Table>> Transaction::CommitOnce(bool 
is_first_attempt) {
       ICEBERG_CHECK(CanRetry(),
                     "Cannot rebase a transaction containing a non-retryable 
update");
       CleanupUpdates();
-      ctx_->metadata_builder =
-          TableMetadataBuilder::BuildFrom(ctx_->table->metadata().get());
+      auto base_metadata = ctx_->table->metadata();

Review Comment:
   it seems the builder and base_metadata needs to be updated together wonder 
if it'd be nice to unify this with a helper or even 
TableMetadataBuilder::BuildFrom to take base as a shared pointer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to