amogh-jahagirdar commented on code in PR #19019:
URL: https://github.com/apache/iceberg/pull/19019#discussion_r4617583735


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -230,6 +230,11 @@ default Long firstRowId() {
     return null;
   }
 
+  /** Returns the microsecond timestamp of the snapshot that added the 
manifest file. */
+  default Long snapshotTimestampMicros() {

Review Comment:
   should this one just be a `long`? For a manifest file wouldn't we always 
know this (regardless of inheritance)?



##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -197,6 +197,19 @@ default Long fileSequenceNumber() {
     return null;
   }
 
+  /**
+   * Returns the microsecond timestamp of the snapshot that added or changed 
this file.
+   *
+   * <p>The value is the snapshot's {@code timestamp-ms} converted to 
microseconds and is assigned
+   * at commit.
+   *
+   * <p>Returns null if the snapshot timestamp is unknown. This may happen for 
files in tables with
+   * format version below 4.
+   */
+  default Long snapshotTimestampMicros() {

Review Comment:
   I feel like a better name for the content file API would be 
`lastUpdatedTimestampMicros`? Feels weird to reference snapshot at this 
abstraction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to