stevenzwu commented on code in PR #19019:
URL: https://github.com/apache/iceberg/pull/19019#discussion_r4619459375


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -230,6 +230,11 @@ default Long firstRowId() {
     return null;
   }
 
+  /** Returns the microsecond timestamp of the snapshot that added the 
manifest file. */
+  default Long snapshotTimestampMicros() {

Review Comment:
   For v4 tables (green or upgraded), their manifest files (committed before or 
after the upgrade) would always have it via inheritance.
   
   for v1-v3 tables, their manifest files won't have this. Are you thinking 
about wiring in the snapshot timestamp inheritance for v1-v3 tables too? and 
don't expose the metadata column for v1-v3 tables?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to