rdblue commented on code in PR #18816:
URL: https://github.com/apache/iceberg/pull/18816#discussion_r4621350595
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -480,7 +604,44 @@ V4ManifestReader build() {
partitionProjections(),
requestedStatsFieldIds,
isUncommitted,
- scanMetrics);
+ scanMetrics,
+ changes,
+ deletedReference,
+ changes ? resolveChangeSnapshotId(tracking) : 0L,
+ tracking != null ? readBitmap(tracking.deletedPositions()) : null,
Review Comment:
Push null handling into `readBitmap`.
Also, should `tracking` return `ManifestBitmap` instead of `ByteBuffer`?
Right now this is inconsistent with the `ManifestInfo` API, where we return
`ManifestBitmap` for `manifestDeletionVector`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]