rdblue commented on code in PR #18816:
URL: https://github.com/apache/iceberg/pull/18816#discussion_r4622236538
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -521,11 +682,14 @@ private Map<Integer, StructProjection>
partitionProjections() {
}
private Schema readSchema(boolean includePartition) {
- if (scanPlanning) {
+ if (mode != Mode.DEFAULT) {
Types.StructType statsProjection =
StatsUtil.statsReadSchema(tableSchema, statsFieldIds());
+ // changes mode needs modified_snapshot_id and the deleted/replaced
position bitmaps
Review Comment:
This comment assumes that the reader knows the difference between
`SCAN_TYPE` and `BASE_TYPE`. It would be better to say that scan planning omits
the change fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]