rdblue commented on code in PR #18816:
URL: https://github.com/apache/iceberg/pull/18816#discussion_r4622313574
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -463,12 +584,15 @@ Builder scanMetrics(ScanMetrics newScanMetrics) {
}
V4ManifestReader build() {
- if (scanPlanning && requestedStatsFieldIds == null) {
+ if (mode != Mode.DEFAULT && requestedStatsFieldIds == null) {
// only return stats that were requested
requestedStatsFieldIds = ImmutableSet.of();
}
Map<Integer, Evaluator> partitionFilters = projectFilters();
+ boolean changes = mode == Mode.CHANGES;
Review Comment:
Style: this needs a verb. The standard Java convention is to use `isChanges`
for a boolean, but that isn't quite right since this is whether to produce
changes. In Iceberg, we would typically use something like `produceChanges`,
`shouldProduceChanges`, or `isChangesMode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]